Prevent UB in all ASM & OCL kernels that do not anticipate asymmetric padding #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sound like a bug. |
|
Formally speaking, the bug is a reason of an issue. However I do not have specific issues on hand (and would like to avoid spending time for finding these). So this is not a bug fix, technically. |
|
@atamazov LGTM. |
TejashShah
approved these changes
Jul 13, 2020
TejashShah
reviewed
Jul 13, 2020
Out of scope of this PR |
atamazov
changed the title
|
LGTM to be merged. |
|
All tests passed, ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ASM & OCL leftovers of #142.
Disables configs that have asymmetric padding in all Solvers that do not anticipate it. See #142 (comment) for details.
Note that currently asymmetric padding is possible only for even filter sizes. However this PR affects Solvers that support odd filters as well. This is done in order to avoid adding new implicit dependencies (on how we define “asymmetric padding”).