Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clone implementations #9967

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Oct 11, 2024

Summary

Vague title since I don't know better.

What this PR includes:

  1. Fix TextChannel.clone always sending rate_limit_per_user when that's not available for announcement/news channels.

The following are fixes for stuff caused by "Add category parameter to abc.GuildChannel.clone" @ a5f9350:

  1. Add missing category kwarg to VocalGuildChannel.clone.
  2. Remove oudated clone implementations from VoiceChannel & StageChannel as it's handled on VocalGuildChannel since "Update all channel clone implementations" @ 053f29c.
  3. Replace .. versionchanged with .. versionadded for the added category kwarg for consistency.

Relevant API Docs:

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant