Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vignettes: timeseries - ordered observations #3453

Open
jangorecki opened this issue Mar 12, 2019 · 6 comments
Open

vignettes: timeseries - ordered observations #3453

jangorecki opened this issue Mar 12, 2019 · 6 comments

Comments

@jangorecki
Copy link
Member

jangorecki commented Mar 12, 2019

There is wide range of features that data.table has in context of ordered observations, if one works with timeseries data it is definitely worth to be aware of those:

key - clustered index

rleid
shift
rolling funs (yet to be completed)
nafill, setnafill

between
inrange
rolling join
non-equi .EACHI join
foverlaps

IDate, ITime, IDateTime

hour, isoweek, mday, minute, month, quarter, second, wday, week, yday, year

as.data.table.xts, as.xts.data.table

nanotime pkg support in fwrite

@Henrik-P
Copy link

Henrik-P commented Apr 22, 2020

Hi @jangorecki!

A while ago I gave a data.table presentation at work, and now I realize that some of the material in the .Rmd file for the slides possibly may be of some use during the preparation of this vignette.
So far I have short text snippets, and in most cases visualizations, for the following topics:

  • brief on normal join
  • rolling join: nearest, Inf. -Inf, fixed distance
  • non-equi join
  • between & inrange
  • rleid
  • shift
  • nafill & setnafill

Please let me know if this may be something you wish to have a look at. I'm happy to share. And of course: just feel free to ignore it.

@jangorecki
Copy link
Member Author

@Henrik-P sure!

@Henrik-P
Copy link

Henrik-P commented Apr 22, 2020

OK, thanks! I'm not a very skilled github user, so I will need to re-read the Contribution guidelines on how to share the .Rmd file the proper way ;)

@Henrik-P
Copy link

Henrik-P commented Apr 24, 2020

@jangorecki A first draft of the .Rmd file is soon ready. Two questions of a more PR technical character: (1) Is it correct to assume that a test is not relevant for a vignette? At least I could find one for e.g. New vignette -- Usages of .SD. (2) Should I create a NEWS entry despite this is, at least from my perspective, very much work in progress?

Cheers

@Henrik-P Henrik-P mentioned this issue Apr 24, 2020
33 tasks
@jangorecki
Copy link
Member Author

  1. Yes, we don't need new unit tests for vignette. If you want to make your vignette future proof, one good option is to add hidden R chunks (include=F) in Rmd. In those chunks stopifnot()'s, so whenever a code will not meet expectations defined there, the vignette will terminate and not be built, we will easily spot that. But this is not really that important.
  2. We will need NEWS entry ultimately, but vignette is likely to be evolving before it will be merged, so not really important yet.

Please ensure you push to Rdatatable org repo, so it will be easy for others to push commits there.

@MichaelChirico
Copy link
Member

Yes, we don't need new unit tests for vignette. If you want to make your vignette future proof, one good option is to add hidden R chunks (include=F) in Rmd. In those chunks stopifnot()'s, so whenever a code will not meet expectations defined there, the vignette will terminate and not be built, we will easily spot that. But this is not really that important.

very nice trick!

@jangorecki jangorecki removed their assignment May 11, 2020
@mattdowle mattdowle modified the milestones: 1.13.1, 1.13.3 Oct 17, 2020
@mattdowle mattdowle removed this from the 1.14.1 milestone Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants