-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning for set / := when numToDo > nrow(x)? #3557
Comments
unless |
Re @jangorecki 's example, you can use numToDo instead of length(i) then? That count is already recorded with NAs removed as seen in
I guess this would just be adding a warning near the message above Line 344 in 2385354
Related #2022 |
Thanks Frank/Jan, yes Main Q is whether we thing this is |
@MichaelChirico lets start with verbose message, this at least won't make any breaking changes |
isn't it duplicate of #2022 ? |
Follow-up to #2837 inspired by #1885 / #3460
We decided running
duplicated
every time we runset
/:=
to help protect against duplicated assignment is overkill & an efficiency killer.However, when
length(i) > nrow(x)
, there's no need to runduplicated
-- there's guaranteed to be at least one duplicate ini
(Pigeonhole):We could
warn
in this case?The text was updated successfully, but these errors were encountered: