-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyed join with empty data.table and roll='nearest' segfaults #4499
Milestone
Comments
It should raise error that there is no column to join to. In same PR should be fine. |
tlapak
changed the title
Keyed join with empty data.table and roll='nearest' still segfaults
Keyed join with empty data.table and roll='nearest' segfaults
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Somewhat related to #4060 in appearance but crashes on all versions of R. Different mechanism, similar appearance. Found this while working on amending #4272. I'll submit a fix soon (hopefully). Should I put it in with #4272 or submit a separate PR? These are all related in that they are triggered by passing zero length
icols/xcols
toCbmerge
.I'm not a hundred percent on what this should do, but I'd suggest to have it behave the same way for all values of
roll
.The text was updated successfully, but these errors were encountered: