-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow.cartesian when i has no duplicate values #742
Comments
Thanks @nigmastar. We'll take a look at this asap. Regarding your last question: I think this SO post should help. |
Hi Arun, thanks for the link. It helped. So, (besides what you say in the link about the error only for 'huge' results) don't you think that when i has no duplicates, like above, no error should be thrown? Thanks, Michele. |
There've been quite a few issues filed on this topic now. Without giving too much thought, it does appear to me that Bumping all |
Maybe the error can mention "nomatch=0" as a possible solution. |
Please consider the following:
The second join results in 5 rows too, shouldn't both joins above be consistent? (Maybe both like the second)
I also wander, the concept behind the implementation of allow.cartesian is simply 1) output rows has not to be more than max(nrow(x),nrow(i)) or 2) to avoid duplicates in key values of i?
The text was updated successfully, but these errors were encountered: