Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyby= index when i subset is present too #3068

Merged
merged 1 commit into from
Sep 25, 2018
Merged

keyby= index when i subset is present too #3068

merged 1 commit into from
Sep 25, 2018

Conversation

mattdowle
Copy link
Member

Closes #3062

@mattdowle mattdowle added this to the 1.11.8 milestone Sep 25, 2018
@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #3068 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3068      +/-   ##
==========================================
+ Coverage   90.85%   90.86%   +<.01%     
==========================================
  Files          61       61              
  Lines       11803    11807       +4     
==========================================
+ Hits        10724    10728       +4     
  Misses       1079     1079
Impacted Files Coverage Δ
src/uniqlist.c 95.21% <100%> (+0.1%) ⬆️
R/data.table.R 91.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb786ce...4b76beb. Read the comment docs.

@mattdowle mattdowle merged commit 3b8cfce into master Sep 25, 2018
@mattdowle mattdowle deleted the subsetindex branch September 25, 2018 02:21
@renkun-ken
Copy link
Member

Thanks for the fix! I'll re-run my production systems with latest dev and see if there are other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants