Reworked subset.c #3170
Merged
Reworked subset.c #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he catching-and-expand of ALTREP too
Codecov Report
@@ Coverage Diff @@
## master #3170 +/- ##
==========================================
- Coverage 92.18% 92.08% -0.11%
==========================================
Files 61 61
Lines 11587 11583 -4
==========================================
- Hits 10682 10666 -16
- Misses 905 917 +12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3170 +/- ##
==========================================
+ Coverage 92.18% 92.21% +0.02%
==========================================
Files 61 61
Lines 11587 11578 -9
==========================================
- Hits 10682 10677 -5
+ Misses 905 901 -4
Continue to review full report at Codecov.
|
jangorecki
reviewed
Dec 1, 2018
| // Only for use by subsetDT() or subsetVector() below, hence static | ||
| { | ||
| if (!length(target)) return target; | ||
| const int n = length(idx); | ||
| if (length(ans)!=n) error("Internal error: subsetVectorRaw length(ans)==%d n=%d", length(ans), n); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subset.ccomplete for #3165. Other files still to review.Removed all R API use in parallel regions.
Removing the catch-and-expand ALTREP. That's left to R which will do that inside INTEGER(), REAL() etc when they see ALTREP vecs (which is now ok as those R API calls are now outside parallel regions).
Parallel within column rather than across columns: A very big subset of 1 column should benefit from 8 cores now, whereas before that was single threaded.
No
criticalor anything complicated. Simpler.Tighter branch-free loops by dealing with zeros and negatives up-front.
Also makes progress in being able to stop defining
USE_RINTERNALS: should not be needed for this file now either to work or for performance.