natural join follow up PR to cover one line #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3767 +/- ##
==========================================
+ Coverage 99.4% 99.41% +<.01%
==========================================
Files 71 71
Lines 13159 13160 +1
==========================================
+ Hits 13081 13083 +2
+ Misses 78 77 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3767 +/- ##
==========================================
+ Coverage 99.4% 99.41% +<.01%
==========================================
Files 71 71
Lines 13159 13160 +1
==========================================
+ Hits 13081 13083 +2
+ Misses 78 77 -1
Continue to review full report at Codecov.
|
mattdowle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of merging PR #3732 the master branch had a timeout on coverage upload. I reran master coverage upload which worked, but the PR didn't refresh. I guess the PR comparison needs coverage on master at the time, otherwise another commit would be needed to trigger.
Anyway, one line was missed coverage. Covering now in this follow up PR.