.SDcols accepts a function to filter on values #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3991 +/- ##
==========================================
+ Coverage 99.41% 99.41% +<.01%
==========================================
Files 72 72
Lines 13904 13909 +5
==========================================
+ Hits 13823 13828 +5
Misses 81 81
Continue to review full report at Codecov.
|
renkun-ken
reviewed
Jul 21, 2020
| @@ -65,6 +65,9 @@ unit = "s") | |||
| # data.table::fcase 1.49 1.55 1.67 1.71 1.73 1.86 5 | |||
| ``` | |||
|
|
|||
| 7. `.SDcols=is.numeric` now works; i.e., `SDcols=` accepts a function which is used to select the columns of `.SD`, [#3950](https:/Rdatatable/data.table/issues/3950). Any function (even _ad hoc_) that returns scalar `TRUE`/`FALSE` for each column will do; e.g., `.SDcols=!is.character` will return _non_-character columns (_a la_ `Negate()`). Note that `patterns=` can still be used for filtering based on the column names. | |||
There was a problem hiding this comment.
patterns= looks a bit misleading to me, looks like an argument of [, e.g. dt[i, lapply(.SD, mean), patterns="^x"].
There was a problem hiding this comment.
Good spot. I filed to #4642 to fix that.
mattdowle
added a commit
that referenced
this pull request
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3950