Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chin and chmatch length 1 speedup #4121

Merged
merged 3 commits into from
Dec 17, 2019
Merged

chin and chmatch length 1 speedup #4121

merged 3 commits into from
Dec 17, 2019

Conversation

mattdowle
Copy link
Member

Implemented Michael's suggestion here: #4117 (comment)

@MichaelChirico
Copy link
Member

Great! Let's sort the table in is_utc by frequency then (UTC>GMT>Etc/UTC>...). Here, or a separate PR?

@mattdowle
Copy link
Member Author

Ok. In this PR might as well. I'll wait for your commit before merging.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #4121 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4121      +/-   ##
=========================================
+ Coverage    99.4%   99.4%   +<.01%     
=========================================
  Files          72      72              
  Lines       13686   13695       +9     
=========================================
+ Hits        13605   13614       +9     
  Misses         81      81
Impacted Files Coverage Δ
src/chmatch.c 100% <100%> (ø) ⬆️
R/utils.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778c326...58446bf. Read the comment docs.

@mattdowle mattdowle merged commit ecd7a1a into master Dec 17, 2019
@mattdowle mattdowle deleted the chin_length_1_speedup branch December 17, 2019 05:08
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants