Add .NGRP; the number of groups #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4215 +/- ##
==========================================
+ Coverage 99.61% 99.61% +<.01%
==========================================
Files 72 72
Lines 13875 13896 +21
==========================================
+ Hits 13821 13842 +21
Misses 54 54
Continue to review full report at Codecov.
|
jangorecki
reviewed
Jan 30, 2020
There was a problem hiding this comment.
Looks good. We could eventually provide a list of those symbols so it can be accessed programmatically. Users could eventually handle specially such variables in their tools - like removing leading dot in expected column name on output. An example of such tools can be dtplyr
mattdowle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1206 and helps with ad hoc versions of #3060
Open to suggestions for the name,
.GRPNis what I used at first, but.NGRPfeels more natural to me.The issue suggested
.BY.Nbut that doesn't feel very natural to me.If we have a few options I could run a Twitter poll.