Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ties.method="last" to frank #4242

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Add ties.method="last" to frank #4242

merged 1 commit into from
Feb 14, 2020

Conversation

MichaelChirico
Copy link
Member

Closes #1689

@codecov
Copy link

codecov bot commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #4242 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4242      +/-   ##
==========================================
+ Coverage   99.61%   99.61%   +<.01%     
==========================================
  Files          72       72              
  Lines       13867    13873       +6     
==========================================
+ Hits        13813    13819       +6     
  Misses         54       54
Impacted Files Coverage Δ
R/frank.R 100% <100%> (ø) ⬆️
src/frank.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf60f6...7032d16. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.9 milestone Feb 14, 2020
@mattdowle mattdowle merged commit 230cfcf into master Feb 14, 2020
@mattdowle mattdowle deleted the frank-last branch February 14, 2020 00:23
@jangorecki
Copy link
Member

Test 1368 fails on R 3.1

@MichaelChirico MichaelChirico mentioned this pull request Feb 15, 2020
Merged
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Add ties.method="last" to frank
3 participants
@MichaelChirico @jangorecki @mattdowle