Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore.attr Argument to rbindlist Function #6017

Closed
wants to merge 3 commits into from

Conversation

Nj221102
Copy link
Contributor

@Nj221102 Nj221102 commented Mar 20, 2024

Description:

This pull request addresses issue #3911 by adding an ignore.attributes argument to the rbindlist function. When set to TRUE, this argument will enable ignoring strict attributes checking, allowing for more lenient behavior when combining data tables.

Proposed Changes:

  • Added ignore_attr argument to the rbindlist function.
  • When ignore_attr is set to TRUE, strict attributes checking is bypassed.
  • Updated documentation and tests accordingly.
  • Added tests.

Related Issues:

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (3eefbca) to head (d63684a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6017   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          80       80           
  Lines       14884    14887    +3     
=======================================
+ Hits        14513    14516    +3     
  Misses        371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico requested review from ben-schwen and removed request for MichaelChirico March 20, 2024 18:11
@ben-schwen
Copy link
Member

ben-schwen commented Mar 20, 2024

This seems similar/addressing the same as #5446

@Nj221102
Copy link
Contributor Author

This seems similar/addressing the same as #5446

oh no i didn't notice it, sorry let me close this one.

@Nj221102 Nj221102 closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rbindlist could use an "ignore.attributes" argument
2 participants