Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian translation of the gettext messages files #6516

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aitap
Copy link
Contributor

@aitap aitap commented Sep 21, 2024

First of all, big thanks to @Meeko28 and @Kate-lz! This would have never been possible without your work. I hope that you've received your grant payouts, or at least that the paperwork is on the way.

The *.po files are prepared against the current *.pot files, so a few of the strings containing fragmented sentences have been left untranslated.

Questions:

  • Should this pull request be WIP until all the *.pot files are updated? I've got to submit some edits for the R message templates too, and the vignettes and the help pages may need their own rounds of editing too.
  • Where do I put the data.table.ru package with the three vignettes (intro, reshape, importing) and (currently) 25% of the help pages translated? I ended up using a po4a-based workflow for the vignettes (thank you very much @phgrosjean for the hint) and a similar but more handmade workflow for the help files. The resulting package (when built) depends on only data.table and suggests a few of its dependencies (to build vignettes and run examples).

@aitap aitap added the translation issues/PRs related to message translation projects label Sep 21, 2024
@Meeko28
Copy link

Meeko28 commented Sep 21, 2024 via email

@MichaelChirico
Copy link
Member

Should this pull request be WIP until all the *.pot files are updated?

Yea, given our normal workflow is to update .pot near release time, I think it's not ideal to trigger the update now... if it's not too much trouble, we could "left join" the the current .pot to your translations as a PR to merge now, then leave this one pending until the .pot is updated (which will probably end up invalidating some translations here).

@aitap
Copy link
Contributor Author

aitap commented Sep 30, 2024

we could "left join" the the current .pot to your translations as a PR to merge now

Let's try this. I've ran msgmerge -U on both files, so the new translations we had prepared with a manually generated data.table.pot should be commented out, ready for reuse.

@aitap
Copy link
Contributor Author

aitap commented Oct 2, 2024

Should I be preparing a new pull request? I think the current branch will msgmerge cleanly against the current *.pot.files.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (6f3fc8d) to head (6923ad2).
Report is 414 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6516      +/-   ##
==========================================
+ Coverage   97.51%   98.62%   +1.10%     
==========================================
  Files          80       79       -1     
  Lines       14979    14450     -529     
==========================================
- Hits        14607    14251     -356     
+ Misses        372      199     -173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Member

Sorry @aitap, haven't had time to look closely. Will report back soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants