Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: running with --mount causes freezing #267

Closed
3 tasks done
PalmDevs opened this issue Sep 18, 2023 · 6 comments · Fixed by #265 or #281
Closed
3 tasks done

bug: running with --mount causes freezing #267

PalmDevs opened this issue Sep 18, 2023 · 6 comments · Fixed by #265 or #281
Labels
Bug report Something isn't working

Comments

@PalmDevs
Copy link
Member

PalmDevs commented Sep 18, 2023

Type

Error while running the CLI

Bug description

Running the patch subcommand with --mount causes CLI to freeze indefinitely with no logs.

Steps to reproduce

  1. Download latest release of CLI & patches
  2. Run the CLI patch command with the device serial and enable mounting
java -jar cli.jar some.apk -o out.apk -b patch-bundle.jar -d S0MES3R1AL --mount
  1. Observe freezing

Relevant log output

(no logs, CLI freezes right after the command)

Screenshots or videos

image

Solution

No response

Additional context

The exact command I've ran:

java -jar cli.jar patch  app.apk  --patch-bundle patches.jar  --merge integrations.apk  --mount  --device-serial REDACTED  --out app-patched.apk  --options options.json  --keystore revanced.keystore  -e alternative-thumbnails -e always-autorepeat -e comments -e copy-video-url -e custom-branding -e custom-video-buffer -e disable-fullscreen-panels -e disable-zoom-haptics -e enable-debugging -e external-downloads -e hdr-auto-brightness -e hide-album-cards -e hide-artist-card -e hide-autoplay-button -e hide-breaking-news-shelf -e hide-captions-button -e hide-cast-button -e hide-crowdfunding-box -e hide-email-address -e hide-endscreen-cards -e hide-filter-bar -e hide-floating-microphone-button -e hide-info-card -e hide-load-more-button -e hide-player-buttons -e hide-player-overlay -e hide-seekbar -e hide-shorts-components -e hide-timestamp -e hide-video-action-buttons -e hide-watch-in-vr -e open-links-externally -e player-flyout-menu -e premium-heading -e remove-player-controls-background -e swipe-controls -e vanced-microg-support -e wide-searchbar -e compact-header -e music-microg-support -e tasteBuilder-remover  -i client-spoof -i disable-auto-captions -i disable-player-popup-panels -i disable-shorts-on-startup -i hide-ads -i hide-get-premium -i hide-watermark -i minimized-playback -i navigation-buttons -i old-quality-layout -i remember-playback-speed -i remember-video-quality -i return-youtube-dislike -i seekbar-tapping -i sponsorblock -i spoof-app-version -i tablet-mini-player -i theme -i video-ads -i playback-speed -i background-play -i bypass-certificate-checks -i codecs-unlock -i exclusive-audio-playback -i hide-get-premium -i minimized-playback-music -i music-video-ads -i permanent-repeat -i permanent-shuffle -i upgrade-button-remover -i spoof-client

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@PalmDevs PalmDevs added the Bug report Something isn't working label Sep 18, 2023
@oSumAtrIX oSumAtrIX added Waiting on author Further information is requested and removed Waiting on author Further information is requested labels Sep 19, 2023
@oSumAtrIX
Copy link
Member

Looks like this happens when the application you try to mount over is not installed.

@oSumAtrIX oSumAtrIX linked a pull request Sep 19, 2023 that will close this issue
@PalmDevs
Copy link
Member Author

PalmDevs commented Oct 5, 2023

Looks like this happens when the application you try to mount over is not installed.

Seems to happen even when installed too. app.apk is APK for YouTube. Same command as in the issue description.

CLI 4.0.0
Patches 2.192.0
Integrations 0.118.0

image

@PalmDevs
Copy link
Member Author

PalmDevs commented Oct 5, 2023

The issue seems to happen with the utility install --mount command too.

@jedenastka
Copy link

I seem to be having the same issue as this on the latest version, 4.0.2 (which I believe includes the fix?).

@oSumAtrIX
Copy link
Member

Open a new issue

@jedenastka
Copy link

Open a new issue

Didn't know if you'd rather have that or reuse this one. Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
3 participants