Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "(root)" to "mount" install option and "(non-root)" to "install" option #1534

Closed
4 tasks done
JL102 opened this issue Nov 28, 2023 · 7 comments
Closed
4 tasks done
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@JL102
Copy link

JL102 commented Nov 28, 2023

Feature description

When clicking install after patching, a dialog opens with "install" and "mount". I am proposing that the text be changed to "install (non-root)" and "mount (root)" or "mount (requires root)".

Motivation

The "mount" / "insfall" install methods are not quite clear, and I only found out that they are the root/nonroot method after I clicked them. It would be helpful if the text inside the selection dialog included the type of installation so that the user knows what it is before selecting one.

Additional context

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@JL102 JL102 added the Feature request Requesting a new feature that's not implemented yet label Nov 28, 2023
@oSumAtrIX
Copy link
Member

Just adding (Root) to the mount option should be enough

@TheAabedKhan TheAabedKhan linked a pull request Nov 28, 2023 that will close this issue
@TheAabedKhan
Copy link
Member

@oSumAtrIX, our new dialog that has an explanation for the methods should be enough to close this issue. What do you think?

@oSumAtrIX
Copy link
Member

I don't remember the dialog, what does it say?

@TheAabedKhan
Copy link
Member

I just checked it. It doesn't mention root or non-root terms. So, I think we need a separate PR for this. Or should we edit the strings on the existing PR?

@ask9027
Copy link

ask9027 commented Dec 12, 2023

Add option to mout or install(root) patched apk from sdcard.

@neo-neo1

This comment was marked as spam.

@oSumAtrIX
Copy link
Member

ReVanced Manager will soon be released as a full rewrite. Over time, many feature requests have been made for the current version of ReVanced Manager, but to accelerate the development of the new version of ReVanced Manager, we have to focus on it, which I am closing this issue according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

  • Stale for too long/ Low priority/ Maintainers un-interested/ Too complex to realize
  • Feature planned/ already implemented for the new version of ReVanced Manager
  • Already implemented

Regardless, anyone who comes across this feature request can PR it to the current version of ReVanced Manager until the new version is ready. Thanks for your feature request!

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

5 participants