App is not actually installed (yet) when manager says so

[SodaWithoutSparkles]

Type

Error while running the manager

Bug description

Manager does not check if the installed version is the one patched just now

Steps to reproduce

1. Patch YT with latest manager version
2. Make sure revanced is already installed
3. After patching, click install, but don't confirm the dialogue yet
4. Look at the bottom behind the blackened screen, revanced manager thinks the app was updated/installed when you havent actuallt installed it yet

Android version

13

Manager version

0.1.0 (or is it 0.1.1?)

Target package name

com.google.youtube

Target package version.

18.15.40

Installation type

Non-root

Patches selected.

Not relevant

Device logs (exported using Manager settings).

Not relevant

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

Not relevant

Screenshots or videos

Note that the red text have been translated into English

Solution

When patching, also modify the version code to include the UNIX timestamp or a nonce. Like changing it from 18.15.40 to 18.15.40-1682669613. This way, RV manager can check it against the expected one and know if the new one is installed or not, instead of displaying it when the button is pressed

Additional context

No response

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.
• The issue is related solely to the ReVanced Manager and not related to patching errors or patches

[KobeW50]

This causes some people to wonder where the app went because it said it was installed but they don't see it in the app drawer

[KobeW50]

The app does not already need to exist on the device for this bug to occur. It always says "Installed!" when the install button is pressed, even if the package name does not exist on the device. But the timestamp solution will still be useful when dealing with app updates, (although wouldn't a hash check be simpler? Idk these things though 🤷)

Also, if the user exits the manager app while the package installer pop-up prompt of "Do you want to install/update this app?" is present, the pop-up will disappear. And upon re-entering the manager, the manager will just say "Open" and makes it seem like it has been successfully installed.

Although the pop-up disappearing can be blamed on the package installer, the "Open" button and the "Installed!" text should not appear unless the app has indeed been installed.

Screen_Recording_20230523_140609.mp4

[Ushie]

There's no need for a hashmap, timestamp in the version code or anything of the likes of that, Package Manager will return a callback with the result of the installation

[SodaWithoutSparkles]

What if the user decides not to use package manager, but sth like SAI or Shizuku to install?

[cioccarellia]

Same here, also if the user already has a older YT Revanced installed and the installation fails (for signature mismatch), then the app assumes it was installed and crashes the installation view upon click open. Maybe you should make sure that the application installation process actually went through

[validcube]

🎉 Fixed in #1021 and released in ReVanced Manager v1.4.1

If problem persist, feels free to reopen this issue!