Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Patched Version #904

Closed
4 tasks done
kbexit opened this issue May 26, 2023 · 8 comments · Fixed by #1022 or #1011
Closed
4 tasks done

Incorrect Patched Version #904

kbexit opened this issue May 26, 2023 · 8 comments · Fixed by #1022 or #1011
Assignees
Labels
Bug report Something isn't working

Comments

@kbexit
Copy link

kbexit commented May 26, 2023

Type

Other

Bug description

Revanced manager says my apps are older than they actually are. Go into the individual app settings and app info, it tells me the correct version. Minor issue but an annoyance for sure.

Steps to reproduce

Deleted and reinstalled, same issue.

Android version

Android 13 Stock Pixel

Manager version

Version: 1.3.0
Model: Pixel 6 Pro
Android Version: 13
Arch: [arm64-v8a, armeabi-v7a, armeabi]

Target package name

com. google. android. youtube
com. google. android. apps . youtube.music
Com. twitter . android

Target package version.

version 18.19.35 (YouTube)
version 5.39.52 (YouTube Music)
version 9.90.0-release.0 (Twitter)

Installation type

Non-root

Patches selected.

YouTube:
Always Autorepeat
Client Spoof
Comments
Copy Video Url
Custom Branding
Disable Auto Captions
Disable Fullscreen Panels
Disable Player Popup Panels
Disable Shorts On Startup
Disable Zoom Haptics
Downloads
Enable Debugging
Hdr Auto Brightness
Hide Ads
Hide Album Cards
Hide Artist Card
Hide Autoplay Button
Hide Breaking News Shelf
Hide Captions Button
Hide Cast Button
Hide Crowdfunding BoX
Hide Email Address
Hide Endscreen Cards Hide Filter Bar
Hide Floating Microphone Button
Hide Get Premium
Hide Info Cards
Hide Load More Button
Hide Player Buttons
Hide Player Overlay •Hide Seekbar
Hide Shorts Components Hide Timestamp
Hide Video Action Buttons Hide Watch In Vr
•Hide Watermark
Minimized Playback
Navigation Buttons
Old Quality Layout
Open Links Externally ·Premium Heading
Remember Video Quality Return Youtube Dislike
Seekbar Tapping
Sponsorblock
•Spoof App Version
Swipe Controls
•Tablet Mini Player
Theme
Vanced MicroG Support Video Ads
Video Speed
Wide Searchbar

YouTube Music:
Says none (?) I'll retry this again

Twitter:
Dynamic Color
Hide Ads
Hide Recommended Users

Device logs (exported using Manager settings).

--------- beginning of main
05-26 10:01:04.641 32254 32254 E SurfaceSyncer: Failed to find sync for id=0
05-26 10:01:04.641 32254 32254 E SurfaceSyncer: Failed to find sync for id=1
05-26 10:01:04.641 32254 32254 E SurfaceSyncer: Failed to find sync for id=2
05-26 10:01:04.641 32254 32254 E SurfaceSyncer: Failed to find sync for id=3
05-26 10:01:04.641 32254 32254 E SurfaceSyncer: Failed to find sync for id=4
05-26 10:01:04.641 32254 32254 E SurfaceSyncer: Failed to find sync for id=5
05-26 10:01:04.641 32254 32254 E SurfaceSyncer: Failed to find sync for id=6

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

Screenshot_20230526-100243
Screenshot_20230526-100235
Screenshot_20230526-100207
Screenshot_20230526-100202

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager and not related to patching errors or patches
@kbexit kbexit added the Bug report Something isn't working label May 26, 2023
@SilverGreen93
Copy link

I can confirm this on my Xiaomi Mi 10T Pro, MIUI 14, Android 12

@ILoveOpenSourceApplications

I believe this is related to #692.

@kbexit
Copy link
Author

kbexit commented Jun 12, 2023

I believe this is related to #692.

I probably didn't see it because of the title being:
Bug: 'potentially fix apps disappearing when update is available

@ILoveOpenSourceApplications

I named it after the patch which was released to fix an issue, where no patched applications were showing up. Now the apps are showing up thanks to that patch but for some reason the version number and date of update/install isn't changing whenever the user updates the respective application.

@kbexit
Copy link
Author

kbexit commented Jun 12, 2023

I named it after the patch which was released to fix an issue, where no patched applications were showing up. Now the apps are showing up thanks to that patch but for some reason the version number and date of update/install isn't changing whenever the user updates the respective application.

Oh you know what! That might be what my issue is? I have stock pixel ROM (can't afford to buy my phone out since I'm a single income dad) and I disabled my YouTube apps system level to favor Revanced. Maybe it's pulling version from the disabled apps?

@ILoveOpenSourceApplications

Can you confirm whether your disabled YouTube app version matches with the ReVanced YouTube version shown inside the manager. In my experience, the app version remains that of the first YouTube version the user patches and installs via the manager. And in your case that's 18.05.40 and not that of the disabled app version.

@kbexit
Copy link
Author

kbexit commented Jun 12, 2023

Can you confirm whether your disabled YouTube app version matches with the ReVanced YouTube version shown inside the manager. In my experience, the app version remains that of the first YouTube version the user patches and installs via the manager. And in your case that's 18.05.40 and not that of the disabled app version.

Turns out, the disabled app is more updated than what Revanced manager shows too...
Don't know where these numbers are coming from, but it sure is odd.

Also should have known this isn't the case since twitter doesn't come stock on pixel 😅

@validcube
Copy link
Member

validcube commented Jul 15, 2023

🎉 Fixed in #1022 and released in ReVanced Manager v1.4.1

If problem persist, feels free to reopen this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
5 participants