Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: be able to copy the recommended version #990

Closed
4 tasks done
wiiznokes opened this issue Jul 2, 2023 · 13 comments · Fixed by #1151
Closed
4 tasks done

feat: be able to copy the recommended version #990

wiiznokes opened this issue Jul 2, 2023 · 13 comments · Fixed by #1151
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@wiiznokes
Copy link

Type

Functionality

Issue

because it takes a long time to have to remember the right version and write it in a search engine.

Feature

be able to copy the recommended version with its name, example: twitter apk version v9.71.0-release0

Motivation

because it simple to implement

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@wiiznokes wiiznokes added the Feature request Requesting a new feature that's not implemented yet label Jul 2, 2023
@AdiAr11
Copy link
Contributor

AdiAr11 commented Aug 22, 2023

Hi, I would like to work on this issue. Can someone guide me where can i find the recommended version? where would the user have to click to be able to copy the recommended version with its name? Thank you.

@wiiznokes
Copy link
Author

I feel like the best way of doing this is to add a screen when we click on a app which is not installed.
The screen will have a button

  • to comme back to the list
  • copy the recommend version
  • maybe open it on a navigator idk
  • the floating button storage

@wiiznokes
Copy link
Author

The version seems to be fetched via a PatcherApi. See the viewmodel:
https:/ReVanced/revanced-manager/blob/main/lib/ui/views/app_selector/app_selector_viewmodel.dart

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Aug 22, 2023

I think instead of copying, it could launch the browser. In this case, it should be accompanied by a "link" icon to signify an outgoing link.

@AdiAr11
Copy link
Contributor

AdiAr11 commented Aug 22, 2023

So should I try to add just a "link" icon or a whole screen as suggested by @wiiznokes ? @wiiznokes it might be better functionality wise to add a new screen, but im worried there is not much to put that will require a whole screen. what do you guys think?

@oSumAtrIX
Copy link
Member

Next to the package name or version a "link" icon can be added to signify an outgoing link when the label is clicked on.

@AdiAr11
Copy link
Contributor

AdiAr11 commented Aug 22, 2023

@oSumAtrIX , sounds good. will try to implement this. could you help me finding the file where i will have to make this changes if possible? I'll also try to find it as well. Thank you!

@wiiznokes
Copy link
Author

If we add a new screen, the list will be more "visible".
And it will be easier to add functionality like predefined website like appmirror etc.
But I am not a maintainer.

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Aug 22, 2023

No new screen is necessary. The label would open the browser on click.

@oSumAtrIX
Copy link
Member

@AdiAr11 I do not know which file implements it. You can probably find it via a global string search.

@AdiAr11
Copy link
Contributor

AdiAr11 commented Aug 22, 2023

@oSumAtrIX No worries, I will find it. Thank you

@wiiznokes
Copy link
Author

I just saw it has been implemented, nice works!

@indrastorms
Copy link

Should be closed

@Ushie Ushie closed this as completed Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants