Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace deprecated WillPopScope #1604

Merged
merged 1 commit into from
Jan 14, 2024
Merged

refactor: Replace deprecated WillPopScope #1604

merged 1 commit into from
Jan 14, 2024

Conversation

BenjaminHalko
Copy link
Member

Replaces WillPopScope with PopScope

@validcube validcube self-requested a review December 29, 2023 09:42
validcube
validcube approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞 Code LGTM!

@validcube validcube requested a review from Ushie December 31, 2023 02:42
@Ushie Ushie changed the title fix: replace depreciated WillPopScope refactor: Replace deprecated WillPopScope Dec 31, 2023
@BenjaminHalko BenjaminHalko merged commit ef9b1d5 into dev Jan 14, 2024
1 check passed
@BenjaminHalko BenjaminHalko deleted the fix/replace-willPopScope branch January 14, 2024 03:34
@er13
Copy link

er13 commented Jan 27, 2024

@BenjaminHalko & @validcube

@5afaedf:

and once again the back button is broken (at least on android-11) just like in 06ff36c (followed by 7f26c5b)

validcube added a commit that referenced this pull request Feb 15, 2024
@validcube
Revert "refactor: Replace deprecated WillPopScope (#1604)"
1c32b05 
This reverts commit ef9b1d5.

Why is this so hard to implement??? Are we missing something??
@validcube
Copy link
Member

validcube commented Feb 15, 2024 •
edited
Loading

@BenjaminHalko & @validcube

@5afaedf:

and once again the back button is broken (at least on android-11) just like in 06ff36c (followed by 7f26c5b)

We revert it again!! For the second time!

Apparently I have no idea how this work . . . 💀 will have to read the documentation again why this issue keep persisting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX oSumAtrIX approved these changes

@validcube validcube validcube approved these changes

@Ushie Ushie Awaiting requested review from Ushie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenjaminHalko @er13 @validcube @oSumAtrIX