feat: Improve custom API URL dialog #2033
Conversation
validcube
added
the
ReVanced Manager Compose
validcube
changed the title
|
@Axelen123 Is #1973 related? The issue appears to suggest replacing the pref value to actual description in the Settings page for API URL listview's description. I could tackle that here since it's (soon-to-be:tm:) related to this PR. |
|
Sure, you can do it in this PR |
Oh, it looks like you are right. You can unlink the issue or take it on in this PR |
Co-authored-by: oSumAtrIX <[email protected]>
|
Snapshot of a822c25
|
validcube
changed the title
Co-authored-by: Ushie <[email protected]>
| @Preview | ||
| @Composable | ||
| private fun APIUrlDialogPreview() { | ||
| APIUrlDialog("https://example.com") {} |
There was a problem hiding this comment.
Should this not be the default API by default?
There was a problem hiding this comment.
Any value is fine here since this is only shown to developer using Android Studio or any IDE that support rendering a composable.
There was a problem hiding this comment.
I guess using default api makes more sense then
There was a problem hiding this comment.
This section is only to preview the design of the composable, it can be removed from this PR with no consequence
There was a problem hiding this comment.
I am not talking specifically about the section but the text shown in the section. So then either removing or using the default api here works
Script Execution UTC Time: null Signed-off-by: validcube <[email protected]>
Ushie
changed the title
@ https://canary.discord.com/channels/952946952348270622/952987428786941952/1258456626457739415
Note
This PR include three changes
Fix