Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve unsupported patch warnings #2066

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

Ushie
Copy link
Member

@Ushie Ushie commented Jul 17, 2024

image

image

@Ushie Ushie added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jul 17, 2024
@Ushie Ushie self-assigned this Jul 17, 2024
@Ushie Ushie force-pushed the feat/improve-unsupported-patch-warnings branch from c41671f to 2381126 Compare July 17, 2024 23:01
@Ushie Ushie linked an issue Jul 17, 2024 that may be closed by this pull request
4 tasks
@validcube
Copy link
Member

validcube commented Jul 18, 2024

If supported version entries is more than 5, I'd suggest incorporating progressive disclosure design.

@oSumAtrIX
Copy link
Member

What do you progressively dusclose here

@Ushie Ushie marked this pull request as ready for review July 22, 2024 18:47
@Ushie Ushie requested a review from Axelen123 July 25, 2024 21:54
@Ushie Ushie requested a review from Axelen123 July 28, 2024 21:19
@Ushie Ushie requested a review from Axelen123 July 29, 2024 14:39
@Ushie Ushie requested a review from Axelen123 July 29, 2024 15:18
@Ushie Ushie merged commit c18901c into compose-dev Jul 29, 2024
2 checks passed
@Ushie Ushie deleted the feat/improve-unsupported-patch-warnings branch July 29, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Versions repeating in dialog explaining why patches are not compatible
4 participants