Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show manager update dialog #2069

Merged
merged 8 commits into from
Jul 28, 2024
Merged

Conversation

Ushie
Copy link
Member

@Ushie Ushie commented Jul 19, 2024

image

@Ushie Ushie added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jul 19, 2024
@Ushie Ushie self-assigned this Jul 19, 2024
@Ushie
Copy link
Member Author

Ushie commented Jul 19, 2024

Should I remove the AvailableUpdate NotificationCard and add an available update badge in the TopAppBar actions in this same PR?

@Ushie Ushie requested a review from Axelen123 July 19, 2024 15:46
@oSumAtrIX oSumAtrIX marked this pull request as ready for review July 19, 2024 20:50
@Axelen123
Copy link
Member

Should I remove the AvailableUpdate NotificationCard and add an available update badge in the TopAppBar actions in this same PR?

If you think it makes sense to do so, go ahead.

@Ushie Ushie requested a review from Axelen123 July 22, 2024 00:18
@Ushie Ushie force-pushed the feat/show-manager-update-dialog branch from 80b9d69 to 7e78637 Compare July 24, 2024 01:36
@Ushie Ushie requested a review from Axelen123 July 25, 2024 22:28
@Ushie Ushie merged commit afc72ff into compose-dev Jul 28, 2024
2 checks passed
@Ushie Ushie deleted the feat/show-manager-update-dialog branch July 28, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: No easy way to get to update screen after dismissing update banner bug: Update banner in wrong place
3 participants