fix: Make it work on Android 12 and lower by using existing APIs #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LisoUseInAIKyrios
force-pushed
the
fix/inputstream_readallbytes
branch
from
0d71ecd
to
7bb1cab
Compare
oSumAtrIX
changed the title
oSumAtrIX
approved these changes
Oct 15, 2024
|
If it's about 1MB then yeah the buffer could be larger. 8092 or 16384 bytes might be good. |
|
I think, passing 0 makes it use a default buffer size of 16kb. |
oSumAtrIX
reviewed
Oct 15, 2024
src/main/kotlin/app/revanced/patcher/patch/BytecodePatchContext.kt
Outdated
Show resolved
Hide resolved
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
## [20.0.2-dev.1](v20.0.1...v20.0.2-dev.1) (2024-10-15) ### Bug Fixes * Make it work on Android 12 and lower by using existing APIs ([#312](#312)) ([a44802e](a44802e))
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
## [20.0.2](v20.0.1...v20.0.2) (2024-10-17) ### Bug Fixes * Make it work on Android 12 and lower by using existing APIs ([#312](#312)) ([a44802e](a44802e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes patching failure when using Manger and Android 12 or lower.
All other patcher code seems to compile just fine.
Changing the project Android SDK to 8.0 correctly detects the issue. I'm not sure if Android 8.0 can be set in a gradle config file or somewhere else, as changing the project in Android Studio does not change any project files.