Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Hide fullscreen ads): Dark overlay blocks UI when fullscreen ad is supposed to be shown #2562

Closed
3 tasks done
HeroGalak opened this issue Dec 29, 2023 · 0 comments · Fixed by #2554
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@HeroGalak
Copy link

HeroGalak commented Dec 29, 2023

Bug description

To reproduce: Toggle on "Hide fullscreen ads" patch and restart the app until a fullscreen ad is supposed to be shown.

The patch hides correctly the ad but a dark overlay remains, preventing the UI to be used. This will happen at every restart of YT.

Dark overlay at app startup:
Screenshot_20231229_152758_YouTube

Error logs

No response

Solution

Press the back button and the dark overlay disappears. Then turn off Hide Fullscreen ads in the ReVanced settings.

Additional context

Using latest patches and YT recommended version.

I'm sure the problem is behind the "Hide fullscreen ads" because when I got the dark overlay for the second time, I tried to restart the app several times. Every time the overlay was there until I disabled the patch and the ad was shown. After that the next restarts were all fine.

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@HeroGalak HeroGalak added the Bug report Something isn't working label Dec 29, 2023
@KobeW50 KobeW50 mentioned this issue Jan 9, 2024
3 tasks
@oSumAtrIX oSumAtrIX linked a pull request Jan 9, 2024 that will close this issue
1 task
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube): Dark overlay blocks UI when fullscreen ad is supposed to be shown bug(YouTube - Hide fullscreen ads): Dark overlay blocks UI when fullscreen ad is supposed to be shown Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant