Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - DeArrow): HTTP 304 is handled as an error #2596

Closed
3 tasks done
signed-log opened this issue Jan 7, 2024 · 3 comments · Fixed by #2554
Closed
3 tasks done

bug(YouTube - DeArrow): HTTP 304 is handled as an error #2596

signed-log opened this issue Jan 7, 2024 · 3 comments · Fixed by #2554
Labels
Bug report Something isn't working

Comments

@signed-log
Copy link

signed-log commented Jan 7, 2024

Bug description

DeArrow API sometimes returns a HTTP 304: Not Modified.

Happens randomly

  1. Enable DeArrow patch
  2. Turn on DeArrow in Revanced settings
  3. Navigate YouTube

Error logs

No response

Solution

304 means no change, so it should be handled like 200 and not raise an error

Additional context

Device : Oppo Find X5 Pro (ColorOS 14)
YouTube : 18.45.43

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@signed-log signed-log added the Bug report Something isn't working label Jan 7, 2024
@LisoUseInAIKyrios
Copy link
Contributor

Just to confirm, the thumbnail loads correctly in this situation?

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title DeArrow HTTP 304 is handled as an error bug(YouTube - DeArrow): HTTP 304 is handled as an error Jan 8, 2024
@LisoUseInAIKyrios
Copy link
Contributor

I was able to reproduce the issue by temporarily setting the system date a few weeks into the future and then scrolling thru the subscription feed.

The thumbnails load correctly on a 304 status.

@LisoUseInAIKyrios
Copy link
Contributor

Should be fixed on dev release

@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Jan 8, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants