Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(Youtube Music): Compact Header patch fails on 6.35.50 #2630

Closed
3 tasks done
ABCPascal opened this issue Jan 19, 2024 · 2 comments · Fixed by #2924
Closed
3 tasks done

bug(Youtube Music): Compact Header patch fails on 6.35.50 #2630

ABCPascal opened this issue Jan 19, 2024 · 2 comments · Fixed by #2924
Labels
Bug report Something isn't working

Comments

@ABCPascal
Copy link

Bug description

This happens only on v6.35.50 on 6.34.52 everything works fine.

Error logs

- Device Info
ReVanced Manager: 1.18.0
Model: SM-G780F
Android version: 13
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.google.android.apps.youtube.music v6.35.50 (Suggested: Any)
Patches version: v3.2.0
Patches added: Compact header, Permanent repeat, Permanent shuffle
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Copying APK
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing resource cache directory
Decoding resources
Executing patches
Applied 12 patches
Compact header failed: app.revanced.patcher.patch.PatchException
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:185)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:203)
	at app.revanced.patcher.Patcher$apply$1.invoke(Unknown Source:8)
	at app.revanced.patcher.Patcher$apply$1.invoke(Unknown Source:4)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
	at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$2$1.invokeSuspend(MainActivity.kt:341)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$36(MainActivity.kt:340)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$wwTqh4bVDMuwAT_qXBREk8gLHGU(Unknown Source:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda5.run(Unknown Source:24)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: java.lang.NullPointerException
	at app.revanced.patches.music.layout.compactheader.CompactHeaderPatch.execute(CompactHeaderPatch.kt:22)
	at app.revanced.patches.music.layout.compactheader.CompactHeaderPatch.execute(CompactHeaderPatch.kt:11)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:174)
	... 18 more
Compiling patched dex files
Compiled 8 dex files
Compiling modified resources
Signing APK
Patched APK

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ABCPascal ABCPascal added the Bug report Something isn't working label Jan 19, 2024
@cyberboh
Copy link

This happens only on v6.35.50 on 6.34.52 everything works fine.

Once it happened on base 6.35.50 , so 6.35.50+ will affected. Tested on 6.35.51 using CLI also fail

@CagesThrottleUs

This comment was marked as spam.

@oSumAtrIX oSumAtrIX added the Prioritized Prioritization over other issues label Mar 12, 2024
@oSumAtrIX oSumAtrIX linked a pull request Mar 27, 2024 that will close this issue
1 task
@LisoUseInAIKyrios LisoUseInAIKyrios removed the Prioritized Prioritization over other issues label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants