Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the ES modules build where it belongs #3670

Merged
merged 1 commit into from
Jul 26, 2016
Merged

Move the ES modules build where it belongs #3670

merged 1 commit into from
Jul 26, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Jul 26, 2016

No description provided.

@taion
Copy link
Contributor Author

taion commented Jul 26, 2016

(not the trash can... rimshot denied)

@timdorr
Copy link
Member

timdorr commented Jul 26, 2016

Didn't this cause problems last time? I forget the details...

@taion
Copy link
Contributor Author

taion commented Jul 26, 2016

People complained that the move was semver-breaking (they were importing directly from react-router/es6 instead of pointing webpack at jsnext:main). Well, this is a major version bump, so now that's no longer a blocker.

@timdorr
Copy link
Member

timdorr commented Jul 26, 2016

Ah, forgot to check this was on next. All good!

@timdorr timdorr merged commit 38b45b3 into next Jul 26, 2016
@timdorr timdorr deleted the es-build branch July 26, 2016 02:28
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @timdorr