Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement getindex method for ArrowheadMatrix #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nimrais
Copy link
Contributor

@Nimrais Nimrais commented Oct 15, 2024

  1. ArrowheadMatrix:

    • Added getindex with one-time performance warning
    • Enhanced error handling for invalid indices
    • Implemented (isapprox) operator
    • Improved matrix multiplication consistency
  2. InvArrowheadMatrix:

    • Implemented efficient dot(x, A, y) for real vectors
    • Utilized linsolve! to avoid explicit inverse computation
  3. General Improvements:

    • Ensured error consistency with dense matrices
    • Expanded test suite for new features and edge cases
    • Optimized performance with in-place operations

These changes need to these PR's tests to pass ReactiveBayes/ExponentialFamily.jl#206

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.22%. Comparing base (741a8c7) to head (c4c3ba0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   76.80%   77.22%   +0.41%     
==========================================
  Files          12       12              
  Lines        1194     1216      +22     
==========================================
+ Hits          917      939      +22     
  Misses        277      277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants