Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UniformScaling in multivariate normal constructors #176

Closed
bartvanerp opened this issue Jan 9, 2024 · 1 comment · Fixed by #182
Closed

Support UniformScaling in multivariate normal constructors #176

bartvanerp opened this issue Jan 9, 2024 · 1 comment · Fixed by #182
Assignees
Labels
bug Something isn't working

Comments

@bartvanerp
Copy link
Member

I was just running some code from a couple months ago and it seems that we lost the following functionality:

MvNormalMeanCovariance(randn(4), 100I)

It throws

MethodError: no method matching ExponentialFamily.MvNormalMeanCovariance(::Vector{Float64}, ::LinearAlgebra.UniformScaling{Int64})

In terms of user-friendliness the above syntax should be supported again, whilst maintaining the computational benefits of the UniformScaling struct.

@bartvanerp bartvanerp added the bug Something isn't working label Jan 9, 2024
@bvdmitri
Copy link
Member

I've checked [email protected] before integration with ExponentialFamily.jl and it did work there as well, but it materialised the matrix (using the Diagonal type). So its definitely a regression. Can you work on it @bartvanerp ? If yes, I add it to the milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants