-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFE is Infinity when data connects to deterministic nodes #317
Comments
That happens because the BFE procedure is divided into three steps:
For deterministic nodes the second step in the procedure differs, however. Instead of computing an average energy term minus entropies of clusters we simply compute the minus entropy of the inbound edges. This is according to the theory paper. This, however, does not account for the case when observation is connected directly to the outbound edge of the deterministic node. If that happens, the minus entropy of the inbound edges cannot not cancel out the entropy of the outbound edge and that causes problems in the third step. The assumption that all "problematic" entropies will be cancelled out does not hold anymore. @ThijsvdLaar @ismailsenoz please discuss What should we do in case if an outbound edge of a deterministic node is connected directly to an observation? Should it be special-cased? As far as I can recall the theory paper does not include this case. |
@ismailsenoz @ThijsvdLaar, any thoughts on this one? |
When an observation connects to a deterministic node, ReactiveMP counts its entropy but doesn't subtract it, leading to infinity value for BFE since the entropy of a PointMass variable is infinity. This problem doesn't happen to stochastic nodes.
The text was updated successfully, but these errors were encountered: