Update README with badges and package manager info. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichoracek
approved these changes
Apr 29, 2017
| @@ -513,6 +515,26 @@ To add RAC to your application: | |||
| To see a project already set up with RAC, check out [C-41][] or [GroceryList][], | |||
| which are real iOS apps written using ReactiveObjC. | |||
|
|
|||
| #### Carthage | |||
There was a problem hiding this comment.
Should this go above the submodule section (the same way it is in ReactiveCocoa)? It seems like Carthage or CocoaPods would be the most common installation routes over submodules.
There was a problem hiding this comment.
It should have a #### Git Submodules header too, I think.
There was a problem hiding this comment.
Does the section need to be updated though? It seems too complicated if linking the library is enough (in regard to Carthage and Pods).
There was a problem hiding this comment.
I think moving it to the bottom of the list and adding a header is sufficient.
mdiep
approved these changes
Apr 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this enough though?