Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: Add missing NonNull annotations to the standard methods #6766

Closed
6 tasks
akarnokd opened this issue Dec 17, 2019 · 1 comment · Fixed by #6840
Closed
6 tasks

3.x: Add missing NonNull annotations to the standard methods #6766

akarnokd opened this issue Dec 17, 2019 · 1 comment · Fixed by #6840
Assignees
@akarnokd
Labels
3.x Cleanup
Milestone
3.0

Comments

@akarnokd
Copy link
Member

akarnokd commented Dec 17, 2019 •
edited
Loading

Including the return type, parameters and type argument usages on lambdas.

  • Flowable
  • Observable
  • Maybe
  • Single
  • Completable
  • ParallelFlowable

Please do them in separate PRs.
@akarnokd akarnokd added this to the 3.0 milestone Dec 17, 2019
@akarnokd akarnokd self-assigned this Dec 23, 2019
@akarnokd akarnokd mentioned this issue Dec 23, 2019
Merged
@akarnokd
Copy link
Member Author

We can annotate the type arguments on our base interfaces and those should be enough for most of the usage places, however, some 3rd party interfaces need explicit annotations:

  • Publisher<@NonNull
  • Iterable<@NonNull
  • Stream<@NonNull

The original pattern could be Type<AnotherType or Type<? extends locations.

@akarnokd akarnokd mentioned this issue Jan 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akarnokd akarnokd

Labels
3.x Cleanup
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

3.x: Add nullability annotations to type arguments akarnokd/RxJava
1 participant
@akarnokd