Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Change "the source Publisher" in Flowable javadocs to "the current Flowable" #6819

Closed
akarnokd opened this issue Jan 8, 2020 · 1 comment

Comments

@akarnokd
Copy link
Member

akarnokd commented Jan 8, 2020

In instance methods of Flowable, the source should be referred to as the current {@code Flowable}. Currently, it is the source {@link Publisher} due to previous copy-paste and search/replace mistakes.

Similarly, the resulting {@code Publisher} should be the resulting {@code Flowable}.

(Watch out for line breaks in the javadocs when searching for these as patterns).


(?s)(the|a)\s*\*?\s*(source|upstream|resulting)\s*\*?\s*(\{\@code|\{\@link)? Publisher
(?s)this\s*\*?\s*(\{\@code|\{\@link)? Publisher
(?s)new\s*\*?\s*(\{\@code)?\s*Publisher

@akarnokd akarnokd added this to the 3.0 milestone Jan 8, 2020
@akarnokd akarnokd self-assigned this Jan 8, 2020
@akarnokd
Copy link
Member Author

Fixed in #6835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant