Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: Inline Observable.concatMapIterable and flatMapIterable #6828

Closed
akarnokd opened this issue Jan 9, 2020 · 0 comments · Fixed by #6837
Closed

3.x: Inline Observable.concatMapIterable and flatMapIterable #6828

akarnokd opened this issue Jan 9, 2020 · 0 comments · Fixed by #6837
Assignees
@akarnokd
Labels
3.x Cleanup Performance
Milestone
3.0

Comments

@akarnokd
Copy link
Member

akarnokd commented Jan 9, 2020

They can be implemented more efficiently than relying on concatMap or flatMap, similarly to how Flowable implements them.

In addition, the bufferSize overloads make no sense as the operation is completely synchronous and nothing is to be buffered. (In comparison, Flowable.concatMapIterable has to buffer the upstream items because the downstream may not be ready to consume the iterable.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akarnokd akarnokd

Labels
3.x Cleanup Performance
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

3.x: Remove a pointless Observable.concatMapIterable overload akarnokd/RxJava
1 participant
@akarnokd