Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Update withLatestFrom doc about upstream early complete #7289

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jul 1, 2021

  • Add missing note to the one-source withLatestFrom methods.
  • Add a sentence about the case when the upstream completes early and thus no emission happens as no tuple can be formed for the callback.

Resolves #7288

@akarnokd akarnokd added this to the 3.1 milestone Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #7289 (832690d) into 3.x (91a10d4) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7289      +/-   ##
============================================
- Coverage     99.53%   99.52%   -0.01%     
+ Complexity     6759     6756       -3     
============================================
  Files           747      747              
  Lines         47391    47391              
  Branches       6382     6382              
============================================
- Hits          47170    47168       -2     
+ Misses          102      100       -2     
- Partials        119      123       +4     
Impacted Files Coverage Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø)
...va/io/reactivex/rxjava3/subjects/AsyncSubject.java 97.87% <0.00%> (-2.13%) ⬇️
...reactivex/rxjava3/processors/PublishProcessor.java 98.16% <0.00%> (-1.84%) ⬇️
...nternal/operators/parallel/ParallelSortedJoin.java 98.49% <0.00%> (-1.51%) ⬇️
...rnal/operators/flowable/FlowableSequenceEqual.java 98.78% <0.00%> (-1.22%) ⬇️
...ernal/operators/flowable/FlowableFromIterable.java 98.95% <0.00%> (-1.05%) ⬇️
...java3/internal/operators/flowable/FlowableZip.java 98.97% <0.00%> (-1.03%) ⬇️
...3/internal/operators/flowable/FlowablePublish.java 99.00% <0.00%> (-1.00%) ⬇️
...rnal/operators/flowable/FlowableFlatMapSingle.java 93.60% <0.00%> (-0.59%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a10d4...832690d. Read the comment docs.

@akarnokd akarnokd merged commit 4749ab3 into ReactiveX:3.x Jul 5, 2021
@akarnokd akarnokd deleted the WithLatestFromDocExpansion branch July 5, 2021 11:31
sakibguy added a commit to sakibguy/RxJava that referenced this pull request Jul 6, 2021
3.x: Update withLatestFrom doc about upstream early complete (ReactiveX#7289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using withLatestFrom completes without values if other publisher is delayed
2 participants