Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Adjust infrastructure version markers #6421

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

akarnokd
Copy link
Member

This PR updates the 2.x and rxjava2 indicators in some documents and build scripts to target RxJava 3 to io.reactivex.rxjava3.

@akarnokd akarnokd added this to the 3.0 milestone Feb 26, 2019
@akarnokd akarnokd changed the base branch from 2.x to 3.x February 26, 2019 14:04
@akarnokd akarnokd closed this Feb 26, 2019
@akarnokd akarnokd reopened this Feb 26, 2019
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how I feel about a possible version 3

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #6421 into 3.x will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6421      +/-   ##
============================================
- Coverage     98.34%   98.28%   -0.07%     
+ Complexity     6300     6298       -2     
============================================
  Files           675      675              
  Lines         45172    45172              
  Branches       6246     6246              
============================================
- Hits          44425    44396      -29     
- Misses          229      238       +9     
- Partials        518      538      +20
Impacted Files Coverage Δ Complexity Δ
...tivex/internal/operators/single/SingleTimeout.java 96.66% <0%> (-3.34%) 2% <0%> (ø)
...activex/internal/operators/single/SingleCache.java 97.05% <0%> (-2.95%) 23% <0%> (-1%)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 93.06% <0%> (-1.99%) 2% <0%> (ø)
...internal/operators/observable/ObservableCache.java 95.9% <0%> (-1.64%) 34% <0%> (-1%)
...perators/mixed/ObservableConcatMapCompletable.java 98.49% <0%> (-1.51%) 3% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 94.16% <0%> (-1.46%) 2% <0%> (ø)
...internal/operators/flowable/FlowableSwitchMap.java 95.28% <0%> (-1.42%) 3% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
...nal/operators/observable/ObservableScalarXMap.java 96.55% <0%> (-1.15%) 7% <0%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a74adf...c2015b0. Read the comment docs.

@anand-prakash-1
Copy link

HI, this is an .xml file containing some bugs found on this project using FindBugs. Just wanted to report them to you guys. Hope it's useful :)

RxJava-2.x.fbwarnings.zip

@akarnokd akarnokd merged commit 837ca6b into ReactiveX:3.x Jun 6, 2019
@akarnokd akarnokd deleted the Infrastructure3x branch June 6, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants