Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order #6638

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Aug 28, 2019

  • Rename zipIterable to zip
  • Remove zip(ObservableSource<ObservableSource<T>>) and zip(Publisher<Publisher<T>>)
  • Change the order of the tillTheEnd argument in concatMapDelayError and concatMapEagerDelayError to be consistent with other operators taking a boolean parameter before prefetch/maxConcurrency.

Related: #6610

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #6638 into 3.x will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6638      +/-   ##
============================================
- Coverage     98.16%   98.12%   -0.05%     
+ Complexity     6180     6174       -6     
============================================
  Files           678      678              
  Lines         44795    44779      -16     
  Branches       6177     6177              
============================================
- Hits          43975    43940      -35     
- Misses          279      291      +12     
- Partials        541      548       +7
Impacted Files Coverage Δ Complexity Δ
...operators/observable/ObservableInternalHelper.java 100% <ø> (ø) 13 <0> (-1) ⬇️
...nal/operators/flowable/FlowableInternalHelper.java 100% <ø> (ø) 13 <0> (-1) ⬇️
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 561 <4> (-1) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 537 <5> (-1) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 86.8% <0%> (-9.03%) 2% <0%> (ø)
...nternal/operators/observable/ObservableToList.java 91.42% <0%> (-8.58%) 2% <0%> (-1%)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 96.25% <0%> (-1.07%) 5% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.07% <0%> (-0.93%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 97.5% <0%> (-0.84%) 2% <0%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf6392...d273268. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants