Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Rename combineLatest methods that take an array to combineLatestArray #6640

Merged
merged 1 commit into from
Aug 28, 2019
Merged

3.x: Rename combineLatest methods that take an array to combineLatestArray #6640

merged 1 commit into from
Aug 28, 2019

Conversation

vanniktech
Copy link
Collaborator

Renames the methods as suggested

@akarnokd akarnokd added this to the 3.0 milestone Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #6640 into 3.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6640      +/-   ##
============================================
+ Coverage     98.12%   98.16%   +0.03%     
+ Complexity     6192     6189       -3     
============================================
  Files           678      678              
  Lines         44690    44690              
  Branches       6165     6165              
============================================
+ Hits          43854    43871      +17     
+ Misses          294      282      -12     
+ Partials        542      537       -5
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 561 <1> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 537 <1> (ø) ⬇️
...java3/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...rxjava3/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...rnal/operators/observable/ObservableSwitchMap.java 91.57% <0%> (-2.11%) 3% <0%> (ø)
...rxjava3/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 97.29% <0%> (-1.81%) 16% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 89.68% <0%> (-1.59%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 97.5% <0%> (-0.84%) 2% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a07c45e...92fd7b6. Read the comment docs.

@akarnokd akarnokd merged commit c9204b5 into ReactiveX:3.x Aug 28, 2019
@vanniktech vanniktech deleted the combineLatestArray branch August 28, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants