Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Update javadoc for observeOn to mention its eagerness #6700

Merged
merged 2 commits into from
Nov 4, 2019
Merged

3.x: Update javadoc for observeOn to mention its eagerness #6700

merged 2 commits into from
Nov 4, 2019

Conversation

JosemyDuarte
Copy link
Contributor

@JosemyDuarte JosemyDuarte commented Nov 2, 2019

Update javadoc to reflect the eagerness property of observeOn in Flowable and Observable classes.

Resolves #6697

@JosemyDuarte JosemyDuarte changed the title Closes #6697: Update javadoc for observeOn to mention its eagerness Close #6697 - 3.x: Update javadoc for observeOn to mention its eagerness Nov 2, 2019
@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #6700 into 3.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6700      +/-   ##
============================================
+ Coverage     98.12%   98.14%   +0.01%     
+ Complexity     6189     6188       -1     
============================================
  Files           677      677              
  Lines         44657    44657              
  Branches       6170     6170              
============================================
+ Hits          43821    43827       +6     
+ Misses          300      294       -6     
  Partials        536      536
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 559 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <ø> (ø) 537 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.1% <0%> (-3.13%) 2% <0%> (ø)
...activex/rxjava3/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...rxjava3/internal/schedulers/ExecutorScheduler.java 96% <0%> (-1.5%) 10% <0%> (ø)
...ava3/internal/operators/parallel/ParallelJoin.java 92.04% <0%> (-1.14%) 3% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.09% <0%> (-0.91%) 2% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 97.08% <0%> (-0.65%) 6% <0%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9727da...b0e26a3. Read the comment docs.

Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the text after the image and the see as last.

@akarnokd akarnokd changed the title Close #6697 - 3.x: Update javadoc for observeOn to mention its eagerness 3.x: Update javadoc for observeOn to mention its eagerness Nov 2, 2019
@akarnokd akarnokd added this to the 3.0 milestone Nov 2, 2019
@akarnokd akarnokd merged commit 8ed6cc1 into ReactiveX:3.x Nov 4, 2019
@JosemyDuarte JosemyDuarte deleted the 6697-javadoc-observeon-update branch November 4, 2019 09:39
@akarnokd
Copy link
Member

Thanks! Much appreciated!

Would you like to backport the changes to the 2.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: update javadoc for observeOn to mention its eagerness
2 participants