Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add missing startWith overloads #6885

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Conversation

akarnokd
Copy link
Member

Add missing ( add ) startWith overloads

source \ other F O M S C
Flowable present absent add add add
Observable absent present add add add
Maybe add add add add add
Single add add add add add
Completable present present add add present

Related #6852

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

@akarnokd akarnokd added this to the 3.0 milestone Jan 27, 2020
@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #6885 into 3.x will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6885      +/-   ##
============================================
- Coverage     98.29%   98.25%   -0.05%     
- Complexity     6550     6563      +13     
============================================
  Files           735      735              
  Lines         47165    47201      +36     
  Branches       6432     6432              
============================================
+ Hits          46359    46375      +16     
- Misses          290      298       +8     
- Partials        516      528      +12
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 591 <3> (+3) ⬆️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 209 <5> (+5) ⬆️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <100%> (ø) 136 <2> (+2) ⬆️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <100%> (ø) 187 <5> (+5) ⬆️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 561 <3> (+3) ⬆️
...vex/rxjava3/internal/operators/maybe/MaybeAmb.java 96.96% <0%> (-3.04%) 10% <0%> (-1%)
...a/io/reactivex/rxjava3/subjects/SingleSubject.java 97.53% <0%> (-2.47%) 37% <0%> (-1%)
...rnal/operators/observable/ObservableSwitchMap.java 91.57% <0%> (-2.11%) 3% <0%> (ø)
...a3/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-1.71%) 2% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c70d6...9ca388c. Read the comment docs.

@akarnokd akarnokd merged commit f86753a into ReactiveX:3.x Jan 27, 2020
@akarnokd akarnokd deleted the StartWith3x branch September 6, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant