Skip to content

Commit

Permalink
docs(Observable): correct takeUntil comment regarding empty notifier
Browse files Browse the repository at this point in the history
Assuming this empty notifier takeUntil test is correct then I believe
that one of the takeUntil comments is wrong. `takeUntil` will not stop
taking values if the notifier completes without emitting any values.
https:/ReactiveX/rxjs/blob/master/spec/operators/takeUntil-spec.ts#L38-L48
  • Loading branch information
jeffbski committed Feb 26, 2017
1 parent 046b03d commit 85099de
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/operator/takeUntil.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import { subscribeToResult } from '../util/subscribeToResult';
*
* `takeUntil` subscribes and begins mirroring the source Observable. It also
* monitors a second Observable, `notifier` that you provide. If the `notifier`
* emits a value or a complete notification, the output Observable stops
* mirroring the source Observable and completes.
* emits a value, the output Observable stops mirroring the source Observable
* and completes.
*
* @example <caption>Tick every second until the first click happens</caption>
* var interval = Rx.Observable.interval(1000);
Expand Down

0 comments on commit 85099de

Please sign in to comment.