-
Notifications
You must be signed in to change notification settings - Fork 3k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subject.create vs AnonymousSubject.create #2004
Comments
This is really confusing behaviour. I figured, since |
#2002 was merged but that doesn't make |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Related #2002, #2003, #1996, #1975
Currently,
Subject.create
is built to mimic it's behavior in v4 and under. That is thatSubject.create
actually returns anAnonymousSubject
, and not aSubject
.Problem
create
in this library, which is as an alternative tonew
... for example:new Observable(fn)
vsObservable.create(fn)
. This creates confusion for users (and experts, apparently)AnonymousSubject
into it's own module, because there would be a circular reference withSubject
, which has this create method that only creates anAnonymousSubject
.Proposal:
Subject.create
becomes alternative version ofnew Subject
AnonymousSubject.create
does whatSubject.create
does now... which is just an alternative version tonew AnonymousSubject
.AnonymousSubject
to it's own module.The text was updated successfully, but these errors were encountered: