Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop duplicating TypeScript class helpers in every CJS file output #2605

Closed
benlesh opened this issue May 17, 2017 · 2 comments
Closed

Stop duplicating TypeScript class helpers in every CJS file output #2605

benlesh opened this issue May 17, 2017 · 2 comments

Comments

@benlesh
Copy link
Member

benlesh commented May 17, 2017

Currently, we're outputting the class helpers in ever CJS file we output, that means that anyone bundling them will end up having N copies of __extend methods in their bundle, where N in the number of our modules they import that use classes.

This is a particular problem for the Angular team.

cc/ @IgorMinar
@kwonoj
Copy link
Member

kwonoj commented May 17, 2017

Check issue #2436, I guess this is dupe.

@benlesh benlesh mentioned this issue May 17, 2017
Closed
@benlesh
Copy link
Member Author

benlesh commented May 21, 2018

this is done

@benlesh benlesh closed this as completed May 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwonoj @benlesh