Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR in node_modules/rxjs/internal/types.d.ts #4511

Closed
monukanyal2017 opened this issue Jan 30, 2019 · 14 comments
Closed

ERROR in node_modules/rxjs/internal/types.d.ts #4511

monukanyal2017 opened this issue Jan 30, 2019 · 14 comments

Comments

@monukanyal2017
Copy link

Bug Report

Current Behavior
I am getting following errror after using npm start or ng build --prod

ERROR in node_modules/rxjs/internal/types.d.ts(81,44): error TS1005: ';' expected.
node_modules/rxjs/internal/types.d.ts(81,74): error TS1005: ';' expected.
node_modules/rxjs/internal/types.d.ts(81,77): error TS1109: Expression expected.

Expected behavior
npm start or ng build command should run without any error.

Environment

  • Runtime: Node {8.9.0} NPM{6.4.0}
  • RxJS version:6.4.0
@kwonoj
Copy link
Member

kwonoj commented Jan 30, 2019

What's typescript version / and is there reproducible repo?

@monukanyal2017
Copy link
Author

"typescript": "~2.7.0"

@kwonoj
Copy link
Member

kwonoj commented Jan 30, 2019

Per this (#4405 (review)) change, it requires 2.8 version of typescript compiler.

@monukanyal2017
Copy link
Author

@kwonoj should i change it 2.7.0 to 2.8.0? angular version is 6.0.0

@kwonoj
Copy link
Member

kwonoj commented Jan 30, 2019

@monukanyal2017 we are trying to figure out which part is actually affects this, I or @cartant will fill bit more detail here.

@cartant
Copy link
Collaborator

cartant commented Jan 30, 2019

We've investigated the issue and the problem is that some versions of projects generated using Angular CLI have an RxJS dependency of ^6.0.0 and a TypeScript dependency of ~2.7.2.

RxJS version 6.4 uses a conditional type to facilitate some improvements to its types and conditional types were introduced in TypeScript 2.8. We are currently looking into the best way of addressing the problem.

@ErxrilOwl
Copy link

Same issue

@monukanyal2017
Copy link
Author

@cartant , Please let me know , should i install lower version of Rxjs?

@cartant
Copy link
Collaborator

cartant commented Jan 30, 2019

To workaround the issue, you can pin RxJS to 6.3 by changing the dependency version in your package.json for RxJS to "rxjs": "~6.3.3".

@sachin-dbox
Copy link

I am also facing the same issue . updated rxjs to 6.3.3, still getting the same issue.

@benlesh
Copy link
Member

benlesh commented Jan 30, 2019

I've created a new issue to track this problem here #4512.

@benlesh benlesh closed this as completed Jan 30, 2019
@benlesh
Copy link
Member

benlesh commented Jan 30, 2019

@sachin-dbox, if you can create a minimum reproduction of that, please file a new issue and link in there. Happy to help if we can.

@NdumisoMthembu
Copy link

Updating type script worked for me npm install -g typescript@latest

@ReactiveX ReactiveX locked as resolved and limited conversation to collaborators Feb 1, 2019
@cartant
Copy link
Collaborator

cartant commented Feb 1, 2019

Locking this. Refer to #4512

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants