Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shareResults): add shareResults operator #2043

Closed
wants to merge 3 commits into from
Closed

feat(shareResults): add shareResults operator #2043

wants to merge 3 commits into from

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Oct 17, 2016 •
edited
Loading

Adds a very basic implementation of the shareResults operator proposed in #2013

TODO:

  • basic impl
  • documentation with examples
  • flush out test suite
  • add perf tests (against nothing in Rx4, because it does not exist there)
  • optimize closures

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.057% when pulling 6dfb619 on blesh:shareResults into 5460e77 on ReactiveX:master.

@coveralls
Copy link

coveralls commented Dec 16, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 97.686% when pulling 43c065f on blesh:shareResults into dc06e01 on ReactiveX:master.

@coveralls
Copy link

coveralls commented Dec 16, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 97.686% when pulling 43c065f on blesh:shareResults into dc06e01 on ReactiveX:master.

@benlesh benlesh mentioned this pull request Mar 4, 2017
Merged
@benlesh
Copy link
Member Author

benlesh commented Mar 4, 2017

I think this PR should probably be closed in favor of #2443

benlesh added a commit that referenced this pull request May 9, 2017
@benlesh
feat(shareReplay): adds shareReplay variant of publishReplay (#2443)
5a2266a 
`shareReplay` returns an observable that is the source multicasted over a `ReplaySubject`. That replay subject is recycled on error from the `source`, but not on completion of the source. This makes `shareReplay` ideal for handling things like caching AJAX results, as it's retryable. It's repeat behavior, however, differs from `share` in that it will not repeat the `source` observable, rather it will repeat the `source` observable's values.

related #2013, #453, #2043
@benlesh benlesh closed this Jan 23, 2018
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlesh @coveralls