Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IteratorObservable): clarify the return type of IteratorObservable.create() #2070

Merged
merged 1 commit into from
Nov 4, 2016
Merged

fix(IteratorObservable): clarify the return type of IteratorObservable.create() #2070

merged 1 commit into from
Nov 4, 2016

Conversation

tetsuharuohzeki
Copy link
Contributor

@tetsuharuohzeki tetsuharuohzeki commented Oct 25, 2016 •
edited
Loading

Description:

  • Before this change, if call IteratorObservable.create<number>() with specifying type parameter, the return type of it was IteratorObservable<{}>. This pull request fix this.
    • This might be potential breaking change.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.217% when pulling bb474c6 on saneyuki:clarify-IteratorObservable-create into 260d335 on ReactiveX:master.

@jayphelps jayphelps mentioned this pull request Oct 25, 2016
Merged
@tetsuharuohzeki tetsuharuohzeki force-pushed the clarify-IteratorObservable-create branch from bb474c6 to 62e604c Compare October 25, 2016 19:16
@tetsuharuohzeki
Copy link
Contributor Author

updated the commit message

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.217% when pulling 62e604c on saneyuki:clarify-IteratorObservable-create into 260d335 on ReactiveX:master.

@tetsuharuohzeki tetsuharuohzeki force-pushed the clarify-IteratorObservable-create branch from 62e604c to c978d27 Compare October 26, 2016 04:04
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.217% when pulling c978d27 on saneyuki:clarify-IteratorObservable-create into 0271fab on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.217% when pulling 48908d1 on saneyuki:clarify-IteratorObservable-create into 89612b2 on ReactiveX:master.

@tetsuharuohzeki
fix(IteratorObservable): clarify the return type of IteratorObservabl…
602bcd8 
…e.create()

BREAKING CHANGE - `IteratorObservable.create<T>()` now returns correctly
`Obsevable<T>` with supplied type parameter `T`. This fixes the previous
implmentations which always returns `Obsevable<{}>`.
@tetsuharuohzeki tetsuharuohzeki force-pushed the clarify-IteratorObservable-create branch from 48908d1 to 602bcd8 Compare October 27, 2016 03:05
@coveralls
Copy link

coveralls commented Oct 27, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 97.217% when pulling 62e604c on saneyuki:clarify-IteratorObservable-create into 260d335 on ReactiveX:master.

@benlesh benlesh merged commit 4f0f865 into ReactiveX:master Nov 4, 2016
@tetsuharuohzeki tetsuharuohzeki deleted the clarify-IteratorObservable-create branch November 4, 2016 19:15
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tetsuharuohzeki @coveralls @benlesh