chore(dangerfile): fix test for hot and cold usages without types #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix logic in test for files which use hot and cold helpers but do not provide type declarations for them, so that files that do not use hot and cold helpers at all would not count as false positives.
kwonoj
approved these changes
Feb 5, 2017
|
@Podlas29 yes, was my error to cause some issues. Rebase existing PR will retrigger danger with updated changes. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hi, I just made two prs: #2329 #2328 and automatic checks fail on them, claiming I used
hotandcoldhelpers in modified specs without type declarations for them.Problem is, modified files seem to not use hot and cold helpers at all.
After checking
dangerfile.jsI suspect that logic in that file is flawed, so here is my attempt to fix it.Warning
Note that I had no idea how to test this file, so please do yourself, or just carefully review.
Related issue (if exists):
Failing prs: #2329 #2328