refactor(shareReplay): align logic with var names

[cartant]

Description:

This PR changes isComplete from being always true to representing whether or not
the source is actually complete and changes the logical test accordingly.

Without the change, isComplete is always true and the unsubscribe call made using the subscription to the source can never occur - regardless of the refCount.

With the change, the call will happen, but only if the refCount is zero and the source has completed.

If the source has completed, the unsubscribe call is redundant and the refCount is irrelevant. If you want, the implementation could be simplified to take that into account, like this:

export function shareReplay<T>(bufferSize?: number, windowTime?: number, scheduler?: IScheduler ): MonoTypeOperatorFunction<T> {
  let subject: ReplaySubject<T>;
  let hasError = false;

  return (source: Observable<T>) => new Observable<T>(observer => {
    if (!subject || hasError) {
      hasError = false;
      subject = new ReplaySubject<T>(bufferSize, windowTime, scheduler);
      source.subscribe({
        next(value) { subject.next(value); },
        error(err) {
          hasError = true;
          subject.error(err);
        },
        complete() {
          subject.complete();
        },
      });
    }

    const innerSub = subject.subscribe(observer);

    return () => {
      innerSub.unsubscribe();
    };
  });
};

Related issue (if exists): None

[rxjs-bot]

	Messages
📖

CJS: 1345.6KB, global: 745.3KB (gzipped: 139.9KB), min: 145.4KB (gzipped: 30.9KB)

Generated by 🚫 dangerJS

[coveralls]

Coverage increased (+0.01%) to 97.467% when pulling 0d01628 on cartant:share-replay-logic into 92547a0 on ReactiveX:master.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.